HttpSocket::_configUri() always change config attribute and it is public. This function dont need return it.

Author: jrbasso

cake/libs/http_socket.php

@@ -674,7 +674,7 @@ protected function _decodeChunkedBody($body) {
  * Parses and sets the specified URI into current request configuration.
  *
  * @param mixed $uri URI, See HttpSocket::_parseUri()
- * @return array Current configuration settings
+ * @return boolean If uri has merged in config
  */
 	protected function _configUri($uri = null) {
 		if (empty($uri)) {
@@ -697,7 +697,7 @@ protected function _configUri($uri = null) {
 		);
 		$this->config = Set::merge($this->config, $config);
 		$this->config = Set::merge($this->config, array_intersect_key($this->config['request']['uri'], $this->config));
-		return $this->config;
+		return true;
 	}
 
 /**

cake/tests/cases/libs/http_socket.test.php

@@ -290,12 +290,12 @@ public function testConfigUri() {
 			)
 		);
 		$this->assertEquals($this->Socket->config, $expected);
-		$this->assertEquals($r, $expected);
+		$this->assertTrue($r);
 		$r = $this->Socket->configUri(array('host' => 'www.foo-bar.org'));
 		$expected['host'] = 'www.foo-bar.org';
 		$expected['request']['uri']['host'] = 'www.foo-bar.org';
 		$this->assertEquals($this->Socket->config, $expected);
-		$this->assertEquals($r, $expected);
+		$this->assertTrue($r);
 
 		$r = $this->Socket->configUri('http://www.foo.com');
 		$expected = array(
@@ -314,13 +314,13 @@ public function testConfigUri() {
 			)
 		);
 		$this->assertEquals($this->Socket->config, $expected);
-		$this->assertEquals($r, $expected);
+		$this->assertTrue($r);
 		$r = $this->Socket->configUri('/this-is-broken');
 		$this->assertEquals($this->Socket->config, $expected);
-		$this->assertEquals($r, false);
+		$this->assertFalse($r);
 		$r = $this->Socket->configUri(false);
 		$this->assertEquals($this->Socket->config, $expected);
-		$this->assertEquals($r, false);
+		$this->assertFalse($r);
 	}
 
 /**