Use chdir() instead of calling multiple commands.

This improves compatibility with windows, and continues to work on *nix systems. Refs #5011
cakephp · Oct 30, 2014 · 31cd0ff · 31cd0ff
1 parent 609ca19
commit 31cd0ff
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Shell/Task/PluginTask.php b/src/Shell/Task/PluginTask.php
@@ -264,8 +264,8 @@ protected function _modifyAutoloader($plugin, $path) {
 		}
 
 		try {
-			$command = 'cd ' . escapeshellarg($path) . '; ';
-			$command .= 'php ' . escapeshellarg($composer) . ' dump-autoload';
+			chdir($path);
+			$command = 'php ' . escapeshellarg($composer) . ' dump-autoload';
 			$this->callProcess($command);
 		} catch (\RuntimeException $e) {
 			$error = $e->getMessage();

diff --git a/tests/TestCase/Shell/Task/PluginTaskTest.php b/tests/TestCase/Shell/Task/PluginTaskTest.php
@@ -200,7 +200,7 @@ public function testExecuteUpdateComposer() {
 
 		$this->Task->expects($this->at(3))
 			->method('callProcess')
-			->with('cd ' . escapeshellarg($path) . '; php ' . escapeshellarg('composer.phar') . ' dump-autoload');
+			->with('php ' . escapeshellarg('composer.phar') . ' dump-autoload');
 
 		$this->Task->main('BakeTestPlugin');