Fixing generation of url inputs

cakephp · Feb 24, 2014 · 321df80 · 321df80
1 parent bf0f158
commit 321df80
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/src/View/Helper/FormHelper.php b/src/View/Helper/FormHelper.php
@@ -912,6 +912,9 @@ protected function _getInput($fieldName, $options) {
 				$opts = $options['options'];
 				unset($options['options']);
 				return $this->select($fieldName, $opts, $options);
+			case 'url':
+				$options = $this->_initInputField($fieldName, $options);
+				return $this->widget($options['type'], $options);
 			default:
 				return $this->{$options['type']}($fieldName, $options);
 		}

diff --git a/tests/TestCase/View/Helper/FormHelperTest.php b/tests/TestCase/View/Helper/FormHelperTest.php
@@ -7625,14 +7625,15 @@ public function testHtml5Inputs() {
  * @return void
  */
 	public function testHtml5InputWithInput() {
-		$this->markTestIncomplete('Need to revisit once models work again.');
-		$result = $this->Form->input('User.website', array(
+		$this->Form->create();
+		$this->Form->templates(['groupContainer' => '{{content}}']);
+		$result = $this->Form->input('website', array(
 			'type' => 'url',
-			'value' => 'http://domain.tld',
-			'div' => false,
-			'label' => false));
+			'val' => 'http://domain.tld',
+			'label' => false
+		));
 		$expected = array(
-			'input' => array('type' => 'url', 'name' => 'User[website]', 'id' => 'UserWebsite', 'value' => 'http://domain.tld')
+			'input' => array('type' => 'url', 'name' => 'website', 'id' => 'website', 'value' => 'http://domain.tld')
 		);
 		$this->assertTags($result, $expected);
 	}