Code review comments.

cakephp · Jun 4, 2013 · 3420baa · 3420baa
1 parent e4c737c
commit 3420baa
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/lib/Cake/Database/Schema/PostgresSchema.php b/lib/Cake/Database/Schema/PostgresSchema.php
@@ -231,12 +231,12 @@ public function convertIndexDescription(Table $table, $row) {
 				'type' => $type,
 				'columns' => $columns
 			]);
-		} else {
-			$table->addIndex($name, [
-				'type' => $type,
-				'columns' => $columns
-			]);
+			return;
 		}
+		$table->addIndex($name, [
+			'type' => $type,
+			'columns' => $columns
+		]);
 	}
 
 /**

diff --git a/lib/Cake/Database/Schema/SqliteSchema.php b/lib/Cake/Database/Schema/SqliteSchema.php
@@ -155,7 +155,7 @@ public function describeIndexSql($table) {
 /**
  * Convert an index into the abstract description.
  *
- * Since Sqlite does not have a way to get metadata about all indexes at once,
+ * Since SQLite does not have a way to get metadata about all indexes at once,
  * additional queries are done here. Sqlite constraint names are not
  * stable, and the names for constraints will not match those used to create
  * the table. This is a limitation in Sqlite's metadata features.