Fix issue with dots in request URLs.

Dots in request url's often resulted in an additional get parameter being added. Fixes #2303
cakephp · Nov 27, 2011 · 390db7b · 390db7b
1 parent 6f28522
commit 390db7b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/Cake/Network/CakeRequest.php b/lib/Cake/Network/CakeRequest.php
@@ -184,7 +184,7 @@ protected function _processGet() {
 			$query = $_GET;
 		}
 
-		unset($query['/' . $this->url]);
+		unset($query['/' . str_replace('.', '_', $this->url)]);
 		if (strpos($this->url, '?') !== false) {
 			list(, $querystr) = explode('?', $this->url);
 			parse_str($querystr, $queryArgs);

diff --git a/lib/Cake/Test/Case/Network/CakeRequestTest.php b/lib/Cake/Test/Case/Network/CakeRequestTest.php
@@ -1056,6 +1056,21 @@ public function testBaseUrlNoRewriteWebrootIndex() {
 		$this->assertEquals('/', $request->webroot);
 	}
 
+/**
+ * Test that a request with a . in the main GET parameter is filtered out.
+ * PHP changes GET parameter keys containing dots to _.
+ *
+ * @return void
+ */
+	public function testGetParamsWithDot() {
+		$_GET['/posts/index/add_add'] = '';
+		$_SERVER['SCRIPT_NAME'] = '/cake_dev/app/webroot/index.php';
+		$_SERVER['REQUEST_URI'] = '/cake_dev/posts/index/add.add';
+
+		$request = new CakeRequest();
+		$this->assertEquals(array(), $request->query);
+	}
+
 /**
  * generator for environment configurations
  *