Setting of step for decimal field based on precision.

cakephp · Sep 29, 2013 · 4806d09 · 4806d09
1 parent 091658a
commit 4806d09
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/Cake/Test/Case/View/Helper/FormHelperTest.php b/lib/Cake/Test/Case/View/Helper/FormHelperTest.php
@@ -1883,7 +1883,7 @@ public function testInput() {
 			'label' => array('for'),
 			'Cost Decimal',
 			'/label',
-			'input' => array('name', 'type' => 'number', 'id'),
+			'input' => array('name', 'type' => 'number', 'step' => '0.001', 'id'),
 			'/div',
 		);
 		$this->assertTags($result, $expected);

diff --git a/lib/Cake/View/Helper/FormHelper.php b/lib/Cake/View/Helper/FormHelper.php
@@ -1160,10 +1160,13 @@ protected function _magicOptions($options) {
 			}
 			if (
 				$options['type'] === 'number' &&
-				$type === 'float' &&
 				!isset($options['step'])
 			) {
-				$options['step'] = 'any';
+				if ($type === 'decimal') {
+					$options['step'] = pow(10, -1 * substr($fieldDef['length'], strpos($fieldDef['length'], ',') + 1));
+				} elseif ($type === 'float') {
+					$options['step'] = 'any';
+				}
 			}
 		}