Fixed issue of list() using same variable for PHP-7

In PHP 7 the processing is made from right to left instead of left to right, causing an issue when the same variable is used on the list(). See https://wiki.php.net/rfc/abstract_syntax_tree
cakephp · Jan 24, 2015 · 4c7af86 · 4c7af86
1 parent ca5dee7
commit 4c7af86
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/I18n/Time.php b/src/I18n/Time.php
@@ -113,7 +113,8 @@ class Time extends Carbon implements JsonSerializable
     public function __construct($time = null, $tz = null)
     {
         if ($time instanceof \DateTime) {
-            list($time, $tz) = [$time->format('Y-m-d H:i:s'), $time->getTimeZone()];
+            $tz = $time->getTimeZone();
+            $time = $time->format('Y-m-d H:i:s');
         }
 
         if (is_numeric($time)) {
@@ -694,7 +695,8 @@ public static function parseDateTime($time, $format = null)
         $timeFormat = $pattern = null;
 
         if (is_array($dateFormat)) {
-            list($dateFormat, $timeFormat) = $dateFormat;
+            list($newDateFormat, $timeFormat) = $dateFormat;
+            $dateFormat = $newDateFormat;
         } else {
             $pattern = $dateFormat;
             $dateFormat = null;