Skip to content

Commit

Permalink
Removed crc32() because of *very* common collisions occuring.
Browse files Browse the repository at this point in the history
Does not touch any of the exposed stuff and will not break anything
else (except you know of a collision within crc32 already and make
"use" of it - which can only be malcious.)

Has already been "fixed" in the 2.x branch.
  • Loading branch information
hmic committed Aug 24, 2014
1 parent 72105c2 commit 4e6e2cd
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions cake/libs/model/datasources/dbo_source.php
Expand Up @@ -54,9 +54,8 @@ class DboSource extends DataSource {

/**
* Caches result from query parsing operations. Cached results for both DboSource::name() and
* DboSource::conditions() will be stored here. Method caching uses `md5()` which is
* fast but can collisions more easily than other hashing algorithms. If you have problems
* with collisions, set DboSource::$cacheMethods to false.
* DboSource::conditions() will be stored here. Method caching uses `md5()`. If you have
* problems with collisions, set DboSource::$cacheMethods to false.
*
* @var array
* @access public
Expand Down

0 comments on commit 4e6e2cd

Please sign in to comment.