Add ability to pass exceptions as flash message

cakephp · Jun 5, 2014 · 4fc8d47 · 4fc8d47
1 parent 2abaf3d
commit 4fc8d47
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/src/Controller/Component/FlashComponent.php b/src/Controller/Component/FlashComponent.php
@@ -43,6 +43,9 @@ public function __construct(ComponentRegistry $collection, array $config = []) {
 	}
 
 	public function set($message, $element = null, array $params = array(), $key = 'flash') {
+		if ($message instanceof \Exception) {
+			$message = $message->getMessage();
+		}
 		$this->_writeFlash($message, 'info', $params + compact('element', 'key'));
 	}
 

diff --git a/tests/TestCase/Controller/Component/FlashComponentTest.php b/tests/TestCase/Controller/Component/FlashComponentTest.php
@@ -115,4 +115,19 @@ public function testSet() {
 		$result = $this->Session->read('Message.foobar');
 		$this->assertEquals($expected, $result);
 	}
+
+/**
+ * testSetWithException method
+ *
+ * @return void
+ * @covers \Cake\Controller\Component\FlashComponent::set
+ */
+	public function testSetWithException() {
+		$this->assertNull($this->Session->read('Message.flash'));
+
+		$this->Flash->set(new \Exception('This is a test message'));
+		$expected = ['message' => 'This is a test message', 'params' => ['element' => null], 'type' => 'info'];
+		$result = $this->Session->read('Message.flash');
+		$this->assertEquals($expected, $result);
+	}
 }