Added test code for the warning log message content.

cakephp · Aug 13, 2017 · 4fd7896 · 4fd7896
1 parent f5d982e
commit 4fd7896
Showing 1 changed file with 31 additions and 3 deletions.
diff --git a/tests/TestCase/Database/ConnectionTest.php b/tests/TestCase/Database/ConnectionTest.php
@@ -18,6 +18,7 @@
 use Cake\Database\Driver\Mysql;
 use Cake\Database\Exception\NestedTransactionRollbackException;
 use Cake\Datasource\ConnectionManager;
+use Cake\Log\Log;
 use Cake\TestSuite\TestCase;
 use ReflectionMethod;
 
@@ -52,6 +53,7 @@ public function setUp()
 
     public function tearDown()
     {
+        Log::reset();
         $this->connection->useSavePoints(false);
         unset($this->connection);
         parent::tearDown();
@@ -488,7 +490,7 @@ public function testSimpleTransactions()
     }
 
     /**
-     * Tests that the destructor of Connection does not crash
+     * Tests that the destructor of Connection generates a warning log
      * when transaction is not closed
      *
      * @return void
@@ -500,10 +502,36 @@ public function testCloseConnectionWithUncommittedTransaction()
             ->setMethods(['connect'])
             ->setConstructorArgs([['driver' => $driver]])
             ->getMock();
-        $connection->begin();
-        $this->assertTrue($connection->inTransaction());
+
+        // The returned value of getMock() is referenced by TestCase,
+        // so it's impossible(or difficult) to call __destruct() of it during the test.
+        // Instead, use cloned object.
+        $clonedConnection = clone $connection;
+        $clonedConnection->begin();
+        $this->assertTrue($clonedConnection->inTransaction());
+
+        Log::setConfig('debug', [
+            'engine' => 'File',
+            'path' => LOGS,
+            'levels' => ['notice', 'info', 'debug'],
+            'file' => 'debug',
+        ]);
+        Log::setConfig('error', [
+            'engine' => 'File',
+            'path' => LOGS,
+            'levels' => ['warning', 'error', 'critical', 'alert', 'emergency'],
+            'file' => 'error',
+        ]);
+        $errorLogFile = LOGS . 'error.log';
+        if (file_exists($errorLogFile)) {
+            unlink($errorLogFile);
+        }
 
         // a warning log will be generated by __destruct of Connection.
+        unset($clonedConnection);
+        $this->assertFileExists($errorLogFile);
+        $logContent = file_get_contents($errorLogFile);
+        $this->assertStringMatchesFormat('%AWarning: The connection is going to be closed but the transaction is still active.%A', $logContent);
     }
 
     /**