Avoding if statements and using === null as nano-optimization

cakephp · Apr 24, 2015 · 53a0817 · 53a0817
1 parent 2a4b5ae
commit 53a0817
Showing 1 changed file with 3 additions and 10 deletions.
diff --git a/src/Controller/Controller.php b/src/Controller/Controller.php
@@ -258,17 +258,10 @@ public function __construct(Request $request = null, Response $response = null,
             $this->name = $name;
         }
 
-        if (!($request instanceof Request)) {
-            $request = new Request();
-        }
-        $this->setRequest($request);
-
-        if (!($response instanceof Response)) {
-            $response = new Response();
-        }
-        $this->response = $response;
+        $this->setRequest($request !== null ? $request : new Request);
+        $this->response = $response !== null ? $response : new Response;
 
-        if ($eventManager) {
+        if ($eventManager !== null) {
             $this->eventManager($eventManager);
         }