Add dropTableSql()

Add tests for MysqlSchema + Table.
cakephp · May 25, 2013 · 59dd147 · 59dd147
1 parent 1de2699
commit 59dd147
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 1 deletion.
diff --git a/lib/Cake/Database/Schema/MysqlSchema.php b/lib/Cake/Database/Schema/MysqlSchema.php
@@ -168,6 +168,16 @@ public function extraSchemaColumns() {
 		];
 	}
 
+/**
+ * Generate the SQL to drop a table.
+ *
+ * @param Cake\Database\Schema\Table $table Table instance
+ * @return string DROP TABLE sql
+ */
+	public function dropTableSql(Table $table) {
+		return sprintf("DROP TABLE `%s`", $table->name());
+	}
+
 /**
  * Generate the SQL to create a table.
  *
@@ -177,7 +187,7 @@ public function extraSchemaColumns() {
  * @param array $indexes The indexes for the table.
  * @return array Complete CREATE TABLE statement(s)
  */
-	public function createTableSql($table, $columns, $constraints, $indexes) {
+	public function createTableSql(Table $table, $columns, $constraints, $indexes) {
 		$content = implode(",\n", array_merge($columns, $constraints, $indexes));
 		return [sprintf("CREATE TABLE `%s` (\n%s\n)", $table->name(), $content)];
 	}

diff --git a/lib/Cake/Database/Schema/Table.php b/lib/Cake/Database/Schema/Table.php
@@ -349,4 +349,17 @@ public function createTableSql(Connection $connection) {
 		return $dialect->createTableSql($this, $columns, $constraints, $indexes);
 	}
 
+/**
+ * Generate the SQL to drop a table.
+ *
+ * Uses the connection to access the schema dialect to generate platform
+ * specific SQL.
+ *
+ * @param Connection $connection The connection to generate SQL for.
+ * @return string SQL to drop a table.
+ */
+	public function dropTableSql(Connection $connection) {
+		$dialect = $connection->driver()->schemaDialect();
+		return $dialect->dropTableSql($this);
+	}
 }
diff --git a/lib/Cake/Test/TestCase/Database/Schema/MysqlSchemaTest.php b/lib/Cake/Test/TestCase/Database/Schema/MysqlSchemaTest.php
@@ -559,6 +559,22 @@ public function testCreateTableSql() {
 		$this->assertEquals($expected, $result[0]);
 	}
 
+/**
+ * test dropTableSql
+ *
+ * @return void
+ */
+	public function testDropTableSql() {
+		$driver = $this->_getMockedDriver();
+		$connection = $this->getMock('Cake\Database\Connection', array(), array(), '', false);
+		$connection->expects($this->any())->method('driver')
+			->will($this->returnValue($driver));
+
+		$table = new Table('articles');
+		$result = $table->dropTableSql($connection);
+		$this->assertEquals('DROP TABLE `articles`', $result);
+	}
+
 /**
  * Get a schema instance with a mocked driver/pdo instances
  *