Fix notice error on missing argument

If an argument was defined by had no value a notice error would be emitted.
cakephp · Dec 17, 2018 · 5ab3164 · 5ab3164
1 parent 540c353
commit 5ab3164
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/Console/Arguments.php b/src/Console/Arguments.php
@@ -117,7 +117,7 @@ public function hasArgument($name)
     public function getArgument($name)
     {
         $offset = array_search($name, $this->argNames, true);
-        if ($offset === false) {
+        if ($offset === false || !isset($this->args[$offset])) {
             return null;
         }
 

diff --git a/tests/TestCase/Console/ArgumentsTest.php b/tests/TestCase/Console/ArgumentsTest.php
@@ -96,6 +96,20 @@ public function testGetArgument()
         $this->assertNull($args->getArgument('hair'));
     }
 
+    /**
+     * get arguments missing value
+     *
+     * @return void
+     */
+    public function testGetArgumentMissing()
+    {
+        $values = [];
+        $names = ['size', 'color'];
+        $args = new Arguments($values, [], $names);
+        $this->assertNull($args->getArgument('size'));
+        $this->assertNull($args->getArgument('color'));
+    }
+
     /**
      * test getOptions()
      *