Fix fixture manager vendor/plugin edge case

cakephp · Jan 6, 2015 · 5c90686 · 5c90686
1 parent ade0190
commit 5c90686
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 6 deletions.
diff --git a/composer.json b/composer.json
@@ -42,6 +42,7 @@
 	"autoload-dev": {
 		"psr-4": {
 			"Cake\\Test\\": "tests",
+			"Company\\TestPluginThree\\Test\\": "tests/test_app/Plugin/Company/TestPluginThree/tests",
 			"TestApp\\": "tests/test_app/TestApp",
 			"TestPlugin\\": "tests/test_app/Plugin/TestPlugin/src",
 			"TestPlugin\\Test\\": "tests/test_app/Plugin/TestPlugin/tests",

diff --git a/src/TestSuite/Fixture/FixtureManager.php b/src/TestSuite/Fixture/FixtureManager.php
@@ -150,12 +150,10 @@ protected function _loadFixtures($test)
             } elseif ($type === 'app') {
                 $baseNamespace = Configure::read('App.namespace');
             } elseif ($type === 'plugin') {
-                if (strlen($additionalPath)) {
-                    list($plugin, $additionalPath) = explode('.', $additionalPath);
-                } else {
-                    list($plugin, $name) = explode('.', $name);
-                }
-                $baseNamespace = Inflector::camelize(str_replace('\\', '\ ', $plugin));
+                list($plugin, $name) = explode('.', $pathName);
+                $path = implode('\\', explode('/', $plugin));
+                $baseNamespace = Inflector::camelize(str_replace('\\', '\ ', $path));
+                $additionalPath = null;
             } else {
                 $name = $fixture;
             }

diff --git a/tests/TestCase/TestSuite/FixtureManagerTest.php b/tests/TestCase/TestSuite/FixtureManagerTest.php
@@ -72,4 +72,23 @@ public function testFixturizePlugin()
             $fixtures['plugin.test_plugin.articles']
         );
     }
+
+    /**
+    * Test loading app fixtures.
+    *
+    * @return void
+    */
+    public function testFixturizeCustom()
+    {
+        $test = $this->getMock('Cake\TestSuite\TestCase');
+        $test->fixtures = ['plugin.Company/TestPluginThree.articles'];
+        $this->manager->fixturize($test);
+        $fixtures = $this->manager->loaded();
+        $this->assertCount(1, $fixtures);
+        $this->assertArrayHasKey('plugin.Company/TestPluginThree.articles', $fixtures);
+        $this->assertInstanceOf(
+            'Company\TestPluginThree\Test\Fixture\ArticlesFixture',
+            $fixtures['plugin.Company/TestPluginThree.articles']
+        );
+    }
 }