replace for loop with array_diff

cakephp · Jun 14, 2018 · 5e0a10c · 5e0a10c
1 parent 13a063a
commit 5e0a10c
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/src/Http/ServerRequest.php b/src/Http/ServerRequest.php
@@ -590,12 +590,8 @@ public function clientIp()
             $n = count($addresses);
 
             if ($trusted) {
-                for ($i = 1; $i < $n; $i++) {
-                    if (in_array($addresses[$i], $this->trustedProxies) === false) {
-                        $trusted = false;
-                        break;
-                    }
-                }
+                $trusted = array_diff($addresses, $this->trustedProxies);
+                $trusted = (count($trusted) === 1);
             }
 
             if ($trusted) {