Fix Http\Client\Response::getStatusCode() should return int, but retu…

…rn string currently.
cakephp · Dec 21, 2016 · 6176a1e · 6176a1e
1 parent 91974ae
commit 6176a1e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/Http/Client/Response.php b/src/Http/Client/Response.php
@@ -195,7 +195,7 @@ protected function _parseHeaders($headers)
             if (substr($value, 0, 5) === 'HTTP/') {
                 preg_match('/HTTP\/([\d.]+) ([0-9]+)(.*)/i', $value, $matches);
                 $this->protocol = $matches[1];
-                $this->code = $matches[2];
+                $this->code = (int)$matches[2];
                 $this->reasonPhrase = trim($matches[3]);
                 continue;
             }

diff --git a/tests/TestCase/Network/Http/ResponseTest.php b/tests/TestCase/Network/Http/ResponseTest.php
@@ -36,7 +36,7 @@ public function testHeaderParsingPsr7()
         $response = new Response($headers, 'winner!');
 
         $this->assertEquals('1.0', $response->getProtocolVersion());
-        $this->assertEquals(200, $response->getStatusCode());
+        $this->assertSame(200, $response->getStatusCode());
         $this->assertEquals('OK', $response->getReasonPhrase());
         $this->assertEquals(
             'text/html;charset="UTF-8"',
@@ -63,7 +63,7 @@ public function testHeaderParsing()
         ];
         $response = new Response($headers, 'ok');
 
-        $this->assertEquals(200, $response->statusCode());
+        $this->assertSame(200, $response->statusCode());
         $this->assertEquals('1.0', $response->version());
         $this->assertEquals(
             'text/html;charset="UTF-8"',
@@ -86,7 +86,7 @@ public function testHeaderParsing()
         $response = new Response($headers, 'ok');
 
         $this->assertEquals('1.0', $response->version());
-        $this->assertEquals(200, $response->statusCode());
+        $this->assertSame(200, $response->statusCode());
     }
 
     /**
@@ -342,10 +342,10 @@ public function testStatusCode()
             'Content-Type: text/html'
         ];
         $response = new Response($headers, '');
-        $this->assertEquals(404, $response->statusCode());
-        $this->assertEquals(404, $response->getStatusCode());
+        $this->assertSame(404, $response->statusCode());
+        $this->assertSame(404, $response->getStatusCode());
 
-        $this->assertEquals(404, $response->code);
+        $this->assertSame(404, $response->code);
         $this->assertTrue(isset($response->code));
     }