Making direction flag in Set::sort() case insensitive. Test updated. F…

…ixes #5992 git-svn-id: https://svn.cakephp.org/repo/branches/1.2.x.x@7977 3807eeeb-6ff5-0310-8944-8be069107fe0
cakephp · Jan 14, 2009 · 628a79a · 628a79a
1 parent a6250ad
commit 628a79a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/cake/libs/set.php b/cake/libs/set.php
@@ -1086,7 +1086,8 @@ function __flatten($results, $key = null) {
 	function sort($data, $path, $dir) {
 		$result = Set::__flatten(Set::extract($data, $path));
 		list($keys, $values) = array(Set::extract($result, '{n}.id'), Set::extract($result, '{n}.value'));
-
+
+		$dir = strtolower($dir);
 		if ($dir === 'asc') {
 			$dir = SORT_ASC;
 		} elseif ($dir === 'desc') {

diff --git a/cake/tests/cases/libs/set.test.php b/cake/tests/cases/libs/set.test.php
@@ -335,7 +335,7 @@ function testSort() {
 			0 => array('Shirt' => array('color' => 'black')),
 			1 => array('Person' => array('name' => 'Jeff')),
 		);
-		$a = Set::sort($a, '{n}.Person.name', 'asc');
+		$a = Set::sort($a, '{n}.Person.name', 'ASC');
 		$this->assertIdentical($a, $b);
 	}
 /**