Add Cake\Database\Query::disableBufferedResults().

cakephp · Nov 1, 2018 · 631e7df · 631e7df
1 parent 1a91ee7
commit 631e7df
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/src/Database/Query.php b/src/Database/Query.php
@@ -2069,6 +2069,22 @@ public function enableBufferedResults($enable = true)
         return $this;
     }
 
+    /**
+     * Disables buffered results.
+     *
+     * Disabling buffering will consume less memory as fetched results are not
+     * remembered for future iterations.
+     *
+     * @return $this
+     */
+    public function disableBufferedResults()
+    {
+        $this->_dirty();
+        $this->_useBufferedResults = false;
+
+        return $this;
+    }
+
     /**
      * Returns whether buffered results are enabled/disabled.
      *

diff --git a/src/ORM/Behavior/TranslateBehavior.php b/src/ORM/Behavior/TranslateBehavior.php
@@ -334,7 +334,7 @@ public function beforeSave(Event $event, EntityInterface $entity, ArrayObject $o
                 'foreign_key' => $key,
                 'model' => $model
             ])
-            ->enableBufferedResults(false)
+            ->disableBufferedResults()
             ->all()
             ->indexBy('field');
 
@@ -753,7 +753,7 @@ protected function _findExistingTranslations($ruleSet)
             ->select(['id', 'num' => 0])
             ->where(current($ruleSet))
             ->disableHydration()
-            ->enableBufferedResults(false);
+            ->disableBufferedResults();
 
         unset($ruleSet[0]);
         foreach ($ruleSet as $i => $conditions) {