Skip to content

Commit

Permalink
Fix syntax errors in PHP <5.4
Browse files Browse the repository at this point in the history
  • Loading branch information
markstory committed May 28, 2015
1 parent b66c1ce commit 6569183
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/Cake/Controller/Component/RequestHandlerComponent.php
Expand Up @@ -229,7 +229,7 @@ public function startup(Controller $controller) {
*/
public function convertXml($xml) {
try {
$xml = Xml::build($xml, ['readFile' => false]);
$xml = Xml::build($xml, array('readFile' => false));
if (isset($xml->data)) {
return Xml::toArray($xml->data);
}
Expand Down
4 changes: 2 additions & 2 deletions lib/Cake/Test/Case/Utility/XmlTest.php
Expand Up @@ -175,7 +175,7 @@ public function testBuild() {
*/
public function testBuildFromFileWhenDisabled() {
$xml = CAKE . 'Test' . DS . 'Fixture' . DS . 'sample.xml';
$obj = Xml::build($xml, ['readFile' => false]);
$obj = Xml::build($xml, array('readFile' => false));
}

/**
Expand All @@ -186,7 +186,7 @@ public function testBuildFromFileWhenDisabled() {
*/
public function testBuildFromUrlWhenDisabled() {
$xml = 'http://www.google.com';
$obj = Xml::build($xml, ['readFile' => false]);
$obj = Xml::build($xml, array('readFile' => false));
}

/**
Expand Down

4 comments on commit 6569183

@ravage84
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josegonzalez
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markstory
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We all make mistakes sometimes. I just get to do it in front of everyone 😄

@ADmad
Copy link
Member

@ADmad ADmad commented on 6569183 May 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravage84 I am still not convinced he's human. He does these mistakes from time to time on purpose to make us think he's human.

Please sign in to comment.