Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add type check to prevent errors related to Hash::get()
Fixes #3041
- Loading branch information
Fixes #3041
66b2965
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this will break some plugins that are passing objects to represent models in the view :(
66b2965
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hash::get() already has more is_array() checks internally, and a type hint on array, so I don't think its ever worked with object results.
66b2965
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set was able to, though. I'll look into that in future versions