Skip to content

Commit

Permalink
Cleanup from previous commit.
Browse files Browse the repository at this point in the history
Refs #GH-1352
  • Loading branch information
markstory committed Jun 19, 2013
1 parent dc3f911 commit 68db74d
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 20 deletions.
33 changes: 16 additions & 17 deletions lib/Cake/Test/Case/View/Helper/FormHelperTest.php
Expand Up @@ -6630,27 +6630,26 @@ public function testYearAutoExpandRange() {

/**
* testInputDateMaxYear method
*
* Let's say we want to only allow users born from
* 2006 to 2008 to register
* This beeing the first singup page, we still don't have any data
*
* Let's say we want to only allow users born from 2006 to 2008 to register
* This being the first singup page, we still don't have any data
*
* @return void
*/
public function testInputDateMaxYear() {
$this->Form->request->data = array();
$this->Form->create('User');
$result = $this->Form->input('birthday',
array(
'label' => false,
'div' => false,
'type' => 'date',
'dateFormat' => 'DMY',
'minYear' => 2006,
'maxYear' => 2008
)
);
$this->assertContains('value="2008" selected="selected"', $result);
$this->Form->request->data = array();
$this->Form->create('User');
$result = $this->Form->input('birthday',
array(
'label' => false,
'div' => false,
'type' => 'date',
'dateFormat' => 'DMY',
'minYear' => 2006,
'maxYear' => 2008
)
);
$this->assertContains('value="2008" selected="selected"', $result);
}

/**
Expand Down
5 changes: 2 additions & 3 deletions lib/Cake/View/Helper/FormHelper.php
Expand Up @@ -2359,10 +2359,9 @@ public function dateTime($fieldName, $dateFormat = 'DMY', $timeFormat = '12', $a
}

if ($attributes['value'] === null && $attributes['empty'] != true) {
if(!empty($attributes['maxYear']) && $attributes['maxYear'] < date('Y')) {
$attributes['value'] = time();
if (!empty($attributes['maxYear']) && $attributes['maxYear'] < date('Y')) {
$attributes['value'] = strtotime(date($attributes['maxYear'] . '-m-d'));
} else {
$attributes['value'] = time();
}
}

Expand Down

0 comments on commit 68db74d

Please sign in to comment.