Skip to content

Commit

Permalink
Add missing return.
Browse files Browse the repository at this point in the history
  • Loading branch information
markstory committed Aug 20, 2013
1 parent 8ca92a1 commit 6d80d6a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/Cake/Console/Command/ConsoleShell.php
Expand Up @@ -439,7 +439,7 @@ protected function _columns($command) {
*/
protected function _routesReload() {
if (!$this->_loadRoutes()) {
$this->err(__d('cake_console', "There was an error loading the routes config. Please check that the file exists and is free of parse errors."));
return $this->err(__d('cake_console', "There was an error loading the routes config. Please check that the file exists and is free of parse errors."));

This comment has been minimized.

Copy link
@dereuromark

dereuromark Aug 20, 2013

Member

error() would halt - would that be better instead of err() - which would continue - maybe?

This comment has been minimized.

Copy link
@markstory

markstory Aug 20, 2013

Author Member

The code wants to continue as it is an interactive 'console'

This comment has been minimized.

Copy link
@dereuromark

dereuromark Aug 20, 2013

Member

All right :)

}
$this->out(__d('cake_console', "Routes configuration reloaded, %d routes connected", count(Router::$routes)));
}
Expand Down

0 comments on commit 6d80d6a

Please sign in to comment.