Moved the Model namespace into ORM so it can be distributed easier

Also moved ModelAwareTrait to Datasource it I think it makes more sense there
cakephp · Jan 1, 2015 · 73fcf31 · 73fcf31
1 parent ea19e9c
commit 73fcf31
Show file tree

Hide file tree

Showing 19 changed files with 29 additions and 27 deletions.
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -16,7 +16,6 @@
 		<testsuite name="CakePHP Test Suite">
 			<directory>./tests/TestCase/</directory>
 			<!-- Excludes are required in order to let DatabaseSuite decorate the tests -->
-			<exclude>./tests/TestCase/Model/</exclude>
 			<exclude>./tests/TestCase/Database/</exclude>
 			<exclude>./tests/TestCase/ORM/</exclude>
 		</testsuite>

diff --git a/src/Console/Shell.php b/src/Console/Shell.php
@@ -18,9 +18,9 @@
 use Cake\Console\Exception\ConsoleException;
 use Cake\Core\Configure;
 use Cake\Core\Plugin;
+use Cake\Datasource\ModelAwareTrait;
 use Cake\Filesystem\File;
 use Cake\Log\LogTrait;
-use Cake\Model\ModelAwareTrait;
 use Cake\Utility\Inflector;
 use Cake\Utility\MergeVariablesTrait;
 use Cake\Utility\String;

diff --git a/src/Controller/Controller.php b/src/Controller/Controller.php
@@ -15,11 +15,11 @@
 namespace Cake\Controller;
 
 use Cake\Controller\Exception\MissingActionException;
+use Cake\Datasource\ModelAwareTrait;
 use Cake\Event\Event;
 use Cake\Event\EventListenerInterface;
 use Cake\Event\EventManagerTrait;
 use Cake\Log\LogTrait;
-use Cake\Model\ModelAwareTrait;
 use Cake\Network\Request;
 use Cake\Network\Response;
 use Cake\ORM\TableRegistry;

diff --git a/...Model/Exception/MissingModelException.php → ...ource/Exception/MissingModelException.php b/...Model/Exception/MissingModelException.php → ...ource/Exception/MissingModelException.php
@@ -12,7 +12,7 @@
  * @since         3.0.0
  * @license       http://www.opensource.org/licenses/mit-license.php MIT License
  */
-namespace Cake\Model\Exception;
+namespace Cake\Datasource\Exception;
 
 use Cake\Core\Exception\Exception;
 

diff --git a/src/Model/ModelAwareTrait.php → src/Datasource/ModelAwareTrait.php b/src/Model/ModelAwareTrait.php → src/Datasource/ModelAwareTrait.php
@@ -12,9 +12,9 @@
  * @since         3.0.0
  * @license       http://www.opensource.org/licenses/mit-license.php MIT License
  */
-namespace Cake\Model;
+namespace Cake\Datasource;
 
-use Cake\Model\Exception\MissingModelException;
+use Cake\Datasource\Exception\MissingModelException;
 use InvalidArgumentException;
 
 /**

diff --git a/src/Model/Behavior/CounterCacheBehavior.php → src/ORM/Behavior/CounterCacheBehavior.php b/src/Model/Behavior/CounterCacheBehavior.php → src/ORM/Behavior/CounterCacheBehavior.php
@@ -12,7 +12,7 @@
  * @since         3.0.0
  * @license       http://www.opensource.org/licenses/mit-license.php MIT License
  */
-namespace Cake\Model\Behavior;
+namespace Cake\ORM\Behavior;
 
 use Cake\Event\Event;
 use Cake\ORM\Association;

diff --git a/src/Model/Behavior/TimestampBehavior.php → src/ORM/Behavior/TimestampBehavior.php b/src/Model/Behavior/TimestampBehavior.php → src/ORM/Behavior/TimestampBehavior.php
@@ -12,7 +12,7 @@
  * @since         3.0.0
  * @license       http://www.opensource.org/licenses/mit-license.php MIT License
  */
-namespace Cake\Model\Behavior;
+namespace Cake\ORM\Behavior;
 
 use Cake\Event\Event;
 use Cake\I18n\Time;

diff --git a/...del/Behavior/Translate/TranslateTrait.php → ...ORM/Behavior/Translate/TranslateTrait.php b/...del/Behavior/Translate/TranslateTrait.php → ...ORM/Behavior/Translate/TranslateTrait.php
@@ -12,7 +12,7 @@
  * @since         3.0.0
  * @license       http://www.opensource.org/licenses/mit-license.php MIT License
  */
-namespace Cake\Model\Behavior\Translate;
+namespace Cake\ORM\Behavior\Translate;
 
 use Cake\ORM\Entity;
 

diff --git a/src/Model/Behavior/TranslateBehavior.php → src/ORM/Behavior/TranslateBehavior.php b/src/Model/Behavior/TranslateBehavior.php → src/ORM/Behavior/TranslateBehavior.php
@@ -12,7 +12,7 @@
  * @since         3.0.0
  * @license       http://www.opensource.org/licenses/mit-license.php MIT License
  */
-namespace Cake\Model\Behavior;
+namespace Cake\ORM\Behavior;
 
 use ArrayObject;
 use Cake\Collection\Collection;

diff --git a/src/Model/Behavior/TreeBehavior.php → src/ORM/Behavior/TreeBehavior.php b/src/Model/Behavior/TreeBehavior.php → src/ORM/Behavior/TreeBehavior.php
@@ -12,7 +12,7 @@
  * @since         3.0.0
  * @license       http://www.opensource.org/licenses/mit-license.php MIT License
  */
-namespace Cake\Model\Behavior;
+namespace Cake\ORM\Behavior;
 
 use Cake\Datasource\Exception\RecordNotFoundException;
 use Cake\Event\Event;

diff --git a/src/ORM/BehaviorRegistry.php b/src/ORM/BehaviorRegistry.php
@@ -76,7 +76,11 @@ public function __construct(Table $table)
      */
     protected function _resolveClassName($class)
     {
-        return App::className($class, 'Model/Behavior', 'Behavior');
+        $result = App::className($class, 'Model/Behavior', 'Behavior');
+        if (!$result && in_array($class, ['CounterCache', 'Timestamp', 'Tree', 'Translate'])) {
+            return 'Cake\ORM\Behavior\\' . $class . 'Behavior';
+        }
+        return $result;
     }
 
     /**

diff --git a/src/View/Cell.php b/src/View/Cell.php
@@ -14,9 +14,9 @@
  */
 namespace Cake\View;
 
+use Cake\Datasource\ModelAwareTrait;
 use Cake\Event\EventManager;
 use Cake\Event\EventManagerTrait;
-use Cake\Model\ModelAwareTrait;
 use Cake\Network\Request;
 use Cake\Network\Response;
 use Cake\Utility\Inflector;

diff --git a/tests/TestCase/DatabaseSuite.php b/tests/TestCase/DatabaseSuite.php
@@ -38,7 +38,6 @@ public static function suite()
         $suite->addTestFile(__DIR__ . DS . 'Database' . DS . 'ConnectionTest.php');
         $suite->addTestDirectoryRecursive(__DIR__ . DS . 'Database');
         $suite->addTestDirectoryRecursive(__DIR__ . DS . 'ORM');
-        $suite->addTestDirectoryRecursive(__DIR__ . DS . 'Model');
         return $suite;
     }
 

diff --git a/tests/TestCase/Model/ModelAwareTraitTest.php → ...stCase/Datasource/ModelAwareTraitTest.php b/tests/TestCase/Model/ModelAwareTraitTest.php → ...stCase/Datasource/ModelAwareTraitTest.php
@@ -11,9 +11,9 @@
  * @since         3.0.0
  * @license       http://www.opensource.org/licenses/mit-license.php MIT License
  */
-namespace Cake\Test\TestCase\Model;
+namespace Cake\Test\TestCase\Datasource;
 
-use Cake\Model\ModelAwareTrait;
+use Cake\Datasource\ModelAwareTrait;
 use Cake\TestSuite\TestCase;
 
 /**

diff --git a/...del/Behavior/CounterCacheBehaviorTest.php → ...ORM/Behavior/CounterCacheBehaviorTest.php b/...del/Behavior/CounterCacheBehaviorTest.php → ...ORM/Behavior/CounterCacheBehaviorTest.php
@@ -12,12 +12,12 @@
  * @since         3.0.0
  * @license       http://www.opensource.org/licenses/mit-license.php MIT License
  */
-namespace Cake\Test\TestCase\Model\Behavior;
+namespace Cake\Test\TestCase\ORM\Behavior;
 
 use Cake\Database\Query;
 use Cake\Datasource\ConnectionManager;
 use Cake\Event\Event;
-use Cake\Model\Behavior\CounterCacheBehavior;
+use Cake\ORM\Behavior\CounterCacheBehavior;
 use Cake\ORM\Entity;
 use Cake\ORM\Table;
 use Cake\ORM\TableRegistry;

diff --git a/.../Model/Behavior/TimestampBehaviorTest.php → ...se/ORM/Behavior/TimestampBehaviorTest.php b/.../Model/Behavior/TimestampBehaviorTest.php → ...se/ORM/Behavior/TimestampBehaviorTest.php
@@ -12,11 +12,11 @@
  * @since         3.0.0
  * @license       http://www.opensource.org/licenses/mit-license.php MIT License
  */
-namespace Cake\Test\TestCase\Model\Behavior;
+namespace Cake\Test\TestCase\ORM\Behavior;
 
 use Cake\Event\Event;
 use Cake\I18n\Time;
-use Cake\Model\Behavior\TimestampBehavior;
+use Cake\ORM\Behavior\TimestampBehavior;
 use Cake\ORM\Entity;
 use Cake\ORM\TableRegistry;
 use Cake\TestSuite\TestCase;

diff --git a/...Behavior/Translate/TranslateTraitTest.php → ...Behavior/Translate/TranslateTraitTest.php b/...Behavior/Translate/TranslateTraitTest.php → ...Behavior/Translate/TranslateTraitTest.php
@@ -12,9 +12,9 @@
  * @since         3.0.0
  * @license       http://www.opensource.org/licenses/mit-license.php MIT License
  */
-namespace Cake\Test\TestCase\Model\Behavior\Translate;
+namespace Cake\Test\TestCase\ORM\Behavior\Translate;
 
-use Cake\Model\Behavior\Translate\TranslateTrait;
+use Cake\ORM\Behavior\Translate\TranslateTrait;
 use Cake\ORM\Entity;
 use Cake\TestSuite\TestCase;
 

diff --git a/.../Model/Behavior/TranslateBehaviorTest.php → ...se/ORM/Behavior/TranslateBehaviorTest.php b/.../Model/Behavior/TranslateBehaviorTest.php → ...se/ORM/Behavior/TranslateBehaviorTest.php
@@ -12,13 +12,13 @@
  * @since         3.0.0
  * @license       http://www.opensource.org/licenses/mit-license.php MIT License
  */
-namespace Cake\Test\TestCase\Model\Behavior;
+namespace Cake\Test\TestCase\ORM\Behavior;
 
 use Cake\Collection\Collection;
 use Cake\Event\Event;
 use Cake\I18n\I18n;
-use Cake\Model\Behavior\TranslateBehavior;
-use Cake\Model\Behavior\Translate\TranslateTrait;
+use Cake\ORM\Behavior\TranslateBehavior;
+use Cake\ORM\Behavior\Translate\TranslateTrait;
 use Cake\ORM\Entity;
 use Cake\ORM\TableRegistry;
 use Cake\TestSuite\TestCase;

diff --git a/...tCase/Model/Behavior/TreeBehaviorTest.php → ...estCase/ORM/Behavior/TreeBehaviorTest.php b/...tCase/Model/Behavior/TreeBehaviorTest.php → ...estCase/ORM/Behavior/TreeBehaviorTest.php
@@ -12,11 +12,11 @@
  * @since         3.0.0
  * @license       http://www.opensource.org/licenses/mit-license.php MIT License
  */
-namespace Cake\Test\TestCase\Model\Behavior;
+namespace Cake\Test\TestCase\ORM\Behavior;
 
 use Cake\Collection\Collection;
 use Cake\Event\Event;
-use Cake\Model\Behavior\TranslateBehavior;
+use Cake\ORM\Behavior\TranslateBehavior;
 use Cake\ORM\Entity;
 use Cake\ORM\TableRegistry;
 use Cake\TestSuite\TestCase;