Postgres' money type should be handled as a string.

The money type contains effectively arbitrary string content before the numbers. Treating this data as a float results in 0.0 for all amounts which is annoying. By handling this type as a string we can give the developer the data they would see in pgadmin. Refs #6193
cakephp · Apr 4, 2015 · 778c80f · 778c80f
1 parent 9eeb4dc
commit 778c80f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/src/Database/Schema/PostgresSchema.php b/src/Database/Schema/PostgresSchema.php
@@ -103,7 +103,11 @@ protected function _convertColumn($column)
         if ($col === 'char' || $col === 'character') {
             return ['type' => 'string', 'fixed' => true, 'length' => $length];
         }
-        if (strpos($col, 'char') !== false) {
+        // money is 'string' as it includes arbitrary text content
+        // before the number value.
+        if (strpos($col, 'char') !== false ||
+            strpos($col, 'money') !== false
+        ) {
             return ['type' => 'string', 'length' => $length];
         }
         if (strpos($col, 'text') !== false) {
@@ -116,7 +120,6 @@ protected function _convertColumn($column)
             return ['type' => 'float', 'length' => null];
         }
         if (strpos($col, 'numeric') !== false ||
-            strpos($col, 'money') !== false ||
             strpos($col, 'decimal') !== false
         ) {
             return ['type' => 'decimal', 'length' => null];

diff --git a/tests/TestCase/Database/Schema/PostgresSchemaTest.php b/tests/TestCase/Database/Schema/PostgresSchemaTest.php
@@ -138,10 +138,6 @@ public static function convertColumnProvider()
                 'DECIMAL(10,2)',
                 ['type' => 'decimal', 'length' => null]
             ],
-            [
-                'MONEY',
-                ['type' => 'decimal', 'length' => null]
-            ],
             // String
             [
                 'VARCHAR',
@@ -167,6 +163,10 @@ public static function convertColumnProvider()
                 'CHARACTER(10)',
                 ['type' => 'string', 'fixed' => true, 'length' => 10]
             ],
+            [
+                'MONEY',
+                ['type' => 'string', 'length' => null]
+            ],
             // UUID
             [
                 'UUID',