Skip to content

Commit 78bee17

Browse files
quickappslorenzo
authored andcommitted
update of test cases
use assertTrue|False instead of `assertEquals`
1 parent e50538f commit 78bee17

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

tests/TestCase/Model/Behavior/TreeBehaviorTest.php

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -166,23 +166,23 @@ public function testMoveUp() {
166166
$table->addBehavior('Tree', ['scope' => ['menu' => 'main-menu']]);
167167

168168
// top level, wont move
169-
$this->assertEquals(false, $this->table->moveUp(1, 10));
169+
$this->assertFalse($this->table->moveUp(1, 10));
170170

171171
// edge cases
172-
$this->assertEquals(false, $this->table->moveUp(1, 0));
173-
$this->assertEquals(false, $this->table->moveUp(1, -10));
172+
$this->assertFalse($this->table->moveUp(1, 0));
173+
$this->assertFalse($this->table->moveUp(1, -10));
174174

175175
// move unexisting node
176-
$this->assertEquals(false, $table->moveUp(500, 1));
176+
$this->assertFalse($table->moveUp(500, 1));
177177

178178
// move inner node
179179
$result = $table->moveUp(3, 1);
180180
$nodes = $table->find('children', ['for' => 1])->all();
181181
$this->assertEquals([3, 4, 5, 2], $nodes->extract('id')->toArray());
182-
$this->assertEquals(true, $result);
182+
$this->assertTrue($result);
183183

184184
// move leaf
185-
$this->assertEquals(false, $table->moveUp(5, 1));
185+
$this->assertFalse($table->moveUp(5, 1));
186186

187187
// move to first position
188188
$table->moveUp(8, true);
@@ -204,24 +204,24 @@ public function testMoveDown() {
204204
$table->addBehavior('Tree', ['scope' => ['menu' => 'main-menu']]);
205205

206206
// latest node, wont move
207-
$this->assertEquals(false, $this->table->moveDown(8, 10));
207+
$this->assertFalse($this->table->moveDown(8, 10));
208208

209209
// edge cases
210-
$this->assertEquals(false, $this->table->moveDown(8, 0));
211-
$this->assertEquals(false, $this->table->moveUp(8, -10));
210+
$this->assertFalse($this->table->moveDown(8, 0));
211+
$this->assertFalse($this->table->moveUp(8, -10));
212212

213213
// move inner node
214214
$nodeIds = [];
215215
$result = $table->moveDown(2, 1);
216216
$nodes = $table->find('children', ['for' => 1])->all();
217217
$this->assertEquals([3, 4, 5, 2], $nodes->extract('id')->toArray());
218-
$this->assertEquals(true, $result);
218+
$this->assertTrue($result);
219219

220220
// move unexisting node
221-
$this->assertEquals(false, $table->moveDown(500, 1));
221+
$this->assertFalse($table->moveDown(500, 1));
222222

223223
// move leaf
224-
$this->assertEquals(false, $table->moveDown(5, 1));
224+
$this->assertFalse( $table->moveDown(5, 1));
225225

226226
// move to last position
227227
$table->moveDown(1, true);

0 commit comments

Comments
 (0)