Removing extra if() that are not needed

as __loadController will stop() execution on error.
cakephp · Jun 5, 2009 · 7cf7a04 · 7cf7a04
1 parent bb566c3
commit 7cf7a04
Showing 1 changed file with 16 additions and 18 deletions.
diff --git a/cake/console/libs/tasks/view.php b/cake/console/libs/tasks/view.php
@@ -129,25 +129,23 @@ function execute() {
 				$this->bake($action, true);
 			} else {
 				$vars = $this->__loadController();
-				if ($vars) {
-					$methods =  array_diff(
-						array_map('strtolower', get_class_methods($this->controllerName . 'Controller')),
-						array_map('strtolower', get_class_methods('appcontroller'))
-					);
-					if (empty($methods)) {
-						$methods = $this->scaffoldActions;
-					}
-					$adminDelete = null;
+				$methods =  array_diff(
+					array_map('strtolower', get_class_methods($this->controllerName . 'Controller')),
+					array_map('strtolower', get_class_methods('appcontroller'))
+				);
+				if (empty($methods)) {
+					$methods = $this->scaffoldActions;
+				}
+				$adminDelete = null;
 
-					$adminRoute = Configure::read('Routing.admin');
-					if (!empty($adminRoute)) {
-						$adminDelete = $adminRoute . '_delete';
-					}
-					foreach ($methods as $method) {
-						if ($method{0} != '_' && !in_array($method, array('delete', $adminDelete))) {
-							$content = $this->getContent($method, $vars);
-							$this->bake($method, $content);
-						}
+				$adminRoute = Configure::read('Routing.admin');
+				if (!empty($adminRoute)) {
+					$adminDelete = $adminRoute . '_delete';
+				}
+				foreach ($methods as $method) {
+					if ($method{0} != '_' && !in_array($method, array('delete', $adminDelete))) {
+						$content = $this->getContent($method, $vars);
+						$this->bake($method, $content);
 					}
 				}
 			}