Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
When a query is executed twice, for example qhen cloned or when marked as dirty, it will run the contain process again. This is potentially dangerous and confusing for some users. The best solution we have for now is to discourage users from resuing a query that was executed before until we find a proper way of handling this case.
- Loading branch information
Showing
4 changed files
with
26 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
851e591
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would keeping track of the containments being processed be a reasonable way of tracking and preventing this issue? That value could be invalidated when contain() or join() is called.
851e591
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would help to some extent, that would definitely be part of a complete solution. My major concern is what happens if the second time a query is executed, the contain conditions, fields or anything related to them changed substantially, for example removing one of them should also remove the join(s) it attached.