Cast length/precision/scale to integers in SQLServer

Schema reflection would leave length as a string when it should be an integer. The same was true for precision and scale. Refs #11296
cakephp · Oct 8, 2017 · 8bc332d · 8bc332d
1 parent 8827866
commit 8bc332d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/Database/Schema/SqlserverSchema.php b/src/Database/Schema/SqlserverSchema.php
@@ -81,6 +81,10 @@ public function describeColumnSql($tableName, $config)
     protected function _convertColumn($col, $length = null, $precision = null, $scale = null)
     {
         $col = strtolower($col);
+        $length = (int)$length;
+        $precision = (int)$precision;
+        $scale = (int)$scale;
+
         if (in_array($col, ['date', 'time'])) {
             return ['type' => $col, 'length' => null];
         }

diff --git a/tests/TestCase/Database/Schema/SqlserverSchemaTest.php b/tests/TestCase/Database/Schema/SqlserverSchemaTest.php
@@ -408,7 +408,7 @@ public function testDescribeTable()
         ];
         $this->assertEquals(['id'], $result->primaryKey());
         foreach ($expected as $field => $definition) {
-            $this->assertEquals($definition, $result->column($field), 'Failed to match field ' . $field);
+            $this->assertSame($definition, $result->column($field), 'Failed to match field ' . $field);
         }
     }