Correctly handle field name for [] suffixed fields.

SecurityComponent was generating a different name for these fields. This format matches the end result of `thing.prop[0]` as well, which is what `thing.prop[]` is getting at. Refs #8170
cakephp · Feb 5, 2016 · 8cc7d38 · 8cc7d38
1 parent 2d54b2a
commit 8cc7d38
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/View/Helper/FormHelper.php b/src/View/Helper/FormHelper.php
@@ -2435,7 +2435,7 @@ protected function _secureFieldName($name)
         $parts = array_map(function ($el) {
             return trim($el, ']');
         }, $parts);
-        return $parts;
+        return array_filter($parts, 'strlen');
     }
 
     /**

diff --git a/tests/TestCase/View/Helper/FormHelperTest.php b/tests/TestCase/View/Helper/FormHelperTest.php
@@ -1746,7 +1746,11 @@ public function testSecuredInputCustomName()
         $this->Form->select('select_box', [1, 2], [
             'name' => 'Option[General.select_role]',
         ]);
-        $expected = ['Option.General.default_role', 'Option.General.select_role'];
+        $expected[] = 'Option.General.select_role';
+        $this->assertEquals($expected, $this->Form->fields);
+
+        $this->Form->text('other.things[]');
+        $expected[] = 'other.things';
         $this->assertEquals($expected, $this->Form->fields);
     }