Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
sort the mimeTypes map alphabetically
except for html which is at the top. Easier maintainance
- Loading branch information
Showing
1 changed file
with
115 additions
and
115 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90ae2df
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure this broke some tests. http://ci.cakephp.org/job/CakePHP%202.3%20-%20Sqlite/446/console
90ae2df
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's annoying - so the map is implicitly order-sensitive..
90ae2df
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it.
90ae2df
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is, also it was reordered so it could fetch more common types faster
90ae2df
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to revert this commit, as it broke tests and made getting at types like json a bit slower.
90ae2df
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were you going to rever this commit mark? 2.3 is still broken in CI
90ae2df
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has already been reverted..?
790a53d
https://github.com/cakephp/cakephp/blob/2.3/lib/Cake/Network/CakeResponse.php
90ae2df
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I saw that @AD7six reverted it and didn't bother.