fix ticket 3400: url string with # in it is not routed

See: http://cakephp.lighthouseapp.com/projects/42648/tickets/3400-url-string-with-in-it-is-not-routed
cakephp · Nov 26, 2012 · 94a17d4 · 94a17d4
1 parent 739982a
commit 94a17d4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/Cake/Routing/Router.php b/lib/Cake/Routing/Router.php
@@ -851,7 +851,7 @@ public static function url($url = null, $full = false) {
 				$output = self::_handleNoRoute($url);
 			}
 		} else {
-			if (preg_match('/:\/\/|^(javascript|mailto|tel|sms):|\#/i', $url)) {
+			if (preg_match('/:\/\/|^(javascript|mailto|tel|sms):|^\#/i', $url)) {
 				return $url;
 			}
 			if (substr($url, 0, 1) === '/') {

diff --git a/lib/Cake/Test/Case/Routing/RouterTest.php b/lib/Cake/Test/Case/Routing/RouterTest.php
@@ -2540,6 +2540,12 @@ public function testUrlProtocol() {
 
 		$url = 'sms:012345-678';
 		$this->assertEquals($url, Router::url($url));
+
+		$url = '#here';
+		$this->assertEquals($url, Router::url($url));
+		$url = 'posts/index#here';
+		$expected = FULL_BASE_URL . '/posts/index#here';
+		$this->assertEquals($expected, Router::url($url, true));
 	}
 
 /**