No startup and teardown for controller tests

and.. no startup/teardown functions unless they are actually going to do more than just call parent
cakephp · Jun 6, 2012 · a5fabcc · ceeram · Jun 6, 2012 · a5fabcc
1 parent 51635c2
commit a5fabcc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/lib/Cake/Console/Command/Task/TestTask.php b/lib/Cake/Console/Command/Task/TestTask.php
@@ -459,11 +459,6 @@ public function generateConstructor($type, $fullClassName, $plugin) {
 		if ($type == 'behavior') {
 			$construct = "new $fullClassName();\n";
 		}
-		if ($type == 'controller') {
-			$className = substr($fullClassName, 0, -10);
-			$construct = "new $fullClassName();\n";
-			$post = "\$this->{$className}->constructClasses();\n";
-		}
 		if ($type == 'helper') {
 			$pre = "\$View = new View();\n";
 			$construct = "new {$fullClassName}(\$View);\n";

diff --git a/lib/Cake/Console/Templates/default/classes/test.ctp b/lib/Cake/Console/Templates/default/classes/test.ctp
@@ -44,6 +44,7 @@ class <?php echo $fullClassName; ?>Test extends CakeTestCase {
 	);
 
 <?php endif; ?>
+<?php if (!empty($construction)): ?>
 /**
  * setUp method
  *
@@ -67,6 +68,7 @@ class <?php echo $fullClassName; ?>Test extends CakeTestCase {
 		parent::tearDown();
 	}
 
+<?php endif; ?>
 <?php foreach ($methods as $method): ?>
 /**
  * test<?php echo Inflector::camelize($method); ?> method