Added strict comparison & created new testcase for duplicate Flash me…

…ssages
cakephp · Dec 6, 2016 · a6342a1 · a6342a1
1 parent 08e17ed
commit a6342a1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/Controller/Component/FlashComponent.php b/src/Controller/Component/FlashComponent.php
@@ -114,7 +114,7 @@ public function set($message, array $options = [])
 
         if ($options['duplicate'] === false) {
             foreach ($messages as $existingMessage) {
-                if ($existingMessage['message'] == $message) {
+                if ($existingMessage['message'] === $message) {
                     return;
                 }
             }

diff --git a/tests/TestCase/Controller/Component/FlashComponentTest.php b/tests/TestCase/Controller/Component/FlashComponentTest.php
@@ -109,12 +109,17 @@ public function testSet()
         $result = $this->Session->read('Flash.foobar');
         $this->assertEquals($expected, $result);
 
+    }
+
+    public function testDuplicateIgnored()
+    {
+        $this->assertNull($this->Session->read('Flash.flash'));
 
         $this->Flash->config('duplicate', false);
         $this->Flash->set('This test message should appear once only');
         $this->Flash->set('This test message should appear once only');
-        $result = array_slice($this->Session->read('Flash.flash'), -2);
-        $this->assertNotEquals($result[0], $result[1]);
+        $result = $this->Session->read('Flash.flash');
+        $this->assertCount(1, $result);
     }
 
     /**