Skip to content

Commit

Permalink
Not using function call inside for loop
Browse files Browse the repository at this point in the history
  • Loading branch information
jeremyharris committed Jun 24, 2017
1 parent 7d44431 commit a6ba59b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/TestSuite/ConsoleIntegrationTestCase.php
Expand Up @@ -188,10 +188,11 @@ protected function _makeRunner()
*/
protected function _commandStringToArgs($command)
{
$charCount = strlen($command);
$argv = [];
$arg = '';
$inQuote = false;
for($i = 0; $i <= strlen($command); $i++) {
for ($i = 0; $i <= $charCount; $i++) {
$char = substr($command, $i, 1);
if ($char === ' ' && !$inQuote) {
$argv[] = $arg;
Expand Down

0 comments on commit a6ba59b

Please sign in to comment.