Make atomic updateAll and deleteAll return the affected rows instead of bool.

Author: euromark

src/Database/Statement/SqliteStatement.php

@@ -32,7 +32,7 @@ public function rowCount() {
 			$changes->execute();
 			$count = $changes->fetch()[0];
 			$changes->closeCursor();
-			return $count;
+			return (int)$count;
 		}
 		return parent::rowCount();
 	}

src/Datasource/RepositoryInterface.php

@@ -76,7 +76,7 @@ public function query();
  * @param array $fields A hash of field => new value.
  * @param mixed $conditions Conditions to be used, accepts anything Query::where()
  * can take.
- * @return bool Success Returns true if one or more rows are affected.
+ * @return int Count Returns the affected rows.
  */
 	public function updateAll($fields, $conditions);
 
@@ -94,7 +94,7 @@ public function updateAll($fields, $conditions);
  *
  * @param mixed $conditions Conditions to be used, accepts anything Query::where()
  * can take.
- * @return bool Success Returns true if one or more rows are affected.
+ * @return int Count Returns the affected rows.
  * @see RepositoryInterface::delete()
  */
 	public function deleteAll($conditions);

src/ORM/Table.php

@@ -1024,9 +1024,8 @@ public function updateAll($fields, $conditions) {
 			->set($fields)
 			->where($conditions);
 		$statement = $query->execute();
-		$success = $statement->rowCount() > 0;
 		$statement->closeCursor();
-		return $success;
+		return $statement->rowCount();
 	}
 
 /**
@@ -1104,9 +1103,8 @@ public function deleteAll($conditions) {
 			->delete()
 			->where($conditions);
 		$statement = $query->execute();
-		$success = $statement->rowCount() > 0;
 		$statement->closeCursor();
-		return $success;
+		return $statement->rowCount();
 	}
 
 /**

tests/TestCase/ORM/TableTest.php

@@ -571,7 +571,7 @@ public function testUpdateAll() {
 		]);
 		$fields = ['username' => 'mark'];
 		$result = $table->updateAll($fields, ['id <' => 4]);
-		$this->assertTrue($result);
+		$this->assertSame(3, $result);
 
 		$result = $table->find('all')
 			->select(['username'])
@@ -617,7 +617,7 @@ public function testDeleteAll() {
 			'connection' => $this->connection,
 		]);
 		$result = $table->deleteAll(['id <' => 4]);
-		$this->assertTrue($result);
+		$this->assertSame(3, $result);
 
 		$result = $table->find('all')->toArray();
 		$this->assertCount(1, $result, 'Only one record should remain');
@@ -636,7 +636,7 @@ public function testDeleteAllAliasedConditions() {
 			'connection' => $this->connection,
 		]);
 		$result = $table->deleteAll(['Managers.id <' => 4]);
-		$this->assertTrue($result);
+		$this->assertSame(3, $result);
 
 		$result = $table->find('all')->toArray();
 		$this->assertCount(1, $result, 'Only one record should remain');