Fix few errors reported by phpstan.

cakephp · Dec 18, 2017 · aa23283 · aa23283
1 parent f3a64e6
commit aa23283
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/Database/Query.php b/src/Database/Query.php
@@ -104,7 +104,7 @@ class Query implements ExpressionInterface, IteratorAggregate
      * The object responsible for generating query placeholders and temporarily store values
      * associated to each of those.
      *
-     * @var \Cake\Database\ValueBinder|false|null
+     * @var \Cake\Database\ValueBinder|null
      */
     protected $_valueBinder;
 
@@ -1870,7 +1870,7 @@ public function getValueBinder()
      * to the statement object.
      *
      * @deprecated 3.5.0 Use getValueBinder() for the getter part instead.
-     * @param \Cake\Database\ValueBinder|false|null $binder new instance to be set. If no value is passed the
+     * @param \Cake\Database\ValueBinder|null $binder new instance to be set. If no value is passed the
      *   default one will be returned
      * @return $this|\Cake\Database\ValueBinder
      */

diff --git a/src/Log/Engine/ConsoleLog.php b/src/Log/Engine/ConsoleLog.php
@@ -91,6 +91,6 @@ public function log($level, $message, array $context = [])
         $message = $this->_format($message, $context);
         $output = date('Y-m-d H:i:s') . ' ' . ucfirst($level) . ': ' . $message;
 
-        return $this->_output->write(sprintf('<%s>%s</%s>', $level, $output, $level));
+        return (bool)$this->_output->write(sprintf('<%s>%s</%s>', $level, $output, $level));
     }
 }
diff --git a/src/ORM/LazyEagerLoader.php b/src/ORM/LazyEagerLoader.php
@@ -76,6 +76,7 @@ protected function _getQuery($objects, $contain, $source)
             return $entity->{$method}($primaryKey);
         });
 
+        /** @var \Cake\ORM\Query $query */
         $query = $source
             ->find()
             ->select((array)$primaryKey)