Skip to content

Commit

Permalink
Revert "updated"
Browse files Browse the repository at this point in the history
This reverts commit 9326fd6.
  • Loading branch information
thinkingmedia committed Nov 17, 2016
1 parent c537b85 commit aa8f1ac
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 26 deletions.
1 change: 0 additions & 1 deletion src/Routing/Route/Route.php
Expand Up @@ -114,7 +114,6 @@ public function __construct($template, $defaults = [], array $options = [])
/**
* Get/Set the supported extensions for this route.
*
* @deprecated 3.3.9
* @param null|string|array $extensions The extensions to set. Use null to get.
* @return array|null The extensions or null.
*/
Expand Down
45 changes: 20 additions & 25 deletions tests/TestCase/Routing/Route/RouteTest.php
Expand Up @@ -52,7 +52,7 @@ public function testConstruction()
}

/**
* Test Route compiling.
* test Route compiling.
*
* @return void
*/
Expand Down Expand Up @@ -124,7 +124,7 @@ public function testRouteParsingWithExtensions()
}

/**
* Test that route parameters that overlap don't cause errors.
* test that route parameters that overlap don't cause errors.
*
* @return void
*/
Expand All @@ -140,7 +140,7 @@ public function testRouteParameterOverlap()
}

/**
* Test compiling routes with keys that have patterns
* test compiling routes with keys that have patterns
*
* @return void
*/
Expand Down Expand Up @@ -209,11 +209,6 @@ public function testRouteCompilingWithParamPatterns()
$this->assertEquals(['url_title', 'id'], $route->keys);
}

/**
* Test routes with unicode patterns.
*
* @return void
*/
public function testRouteCompilingWithUnicodePatterns()
{
$route = new Route(
Expand All @@ -234,7 +229,7 @@ public function testRouteCompilingWithUnicodePatterns()
}

/**
* Test more complex route compiling & parsing with mid route greedy stars
* test more complex route compiling & parsing with mid route greedy stars
* and optional routing parameters
*
* @return void
Expand Down Expand Up @@ -295,7 +290,7 @@ public function testComplexRouteCompilingAndParsing()
}

/**
* Test that routes match their pattern.
* test that routes match their pattern.
*
* @return void
*/
Expand Down Expand Up @@ -444,7 +439,7 @@ public function testMatchWithHostKeys()
}

/**
* Test that non-greedy routes fail with extra passed args
* test that non-greedy routes fail with extra passed args
*
* @return void
*/
Expand All @@ -460,7 +455,7 @@ public function testMatchGreedyRouteFailurePassedArg()
}

/**
* Test that falsey values do not interrupt a match.
* test that falsey values do not interrupt a match.
*
* @return void
*/
Expand All @@ -474,7 +469,7 @@ public function testMatchWithFalseyValues()
}

/**
* Test match() with greedy routes, and passed args.
* test match() with greedy routes, and passed args.
*
* @return void
*/
Expand Down Expand Up @@ -637,7 +632,7 @@ public function testMatchWithExtension()
}

/**
* Test that match with patterns works.
* test that match with patterns works.
*
* @return void
*/
Expand Down Expand Up @@ -691,7 +686,7 @@ public function testMatchExtractQueryStringArgs()
}

/**
* Test separator.
* Test separartor.
*
* @return void
*/
Expand All @@ -716,7 +711,7 @@ public function testQueryStringGeneration()
}

/**
* Test the parse method of Route.
* test the parse method of Route.
*
* @return void
*/
Expand Down Expand Up @@ -784,7 +779,7 @@ public function testParseUrlDecodeElements()
}

/**
* Test numerically indexed defaults, get appended to pass
* test numerically indexed defaults, get appended to pass
*
* @return void
*/
Expand All @@ -802,7 +797,7 @@ public function testParseWithPassDefaults()
}

/**
* Test that http header conditions can cause route failures.
* test that http header conditions can cause route failures.
*
* @return void
*/
Expand All @@ -822,7 +817,7 @@ public function testParseWithHttpHeaderConditions()
}

/**
* Test that http header conditions can cause route failures.
* test that http header conditions can cause route failures.
*
* @return void
*/
Expand All @@ -848,7 +843,7 @@ public function testParseWithMultipleHttpMethodConditions()
}

/**
* Test that http header conditions can work with URL generation
* test that http header conditions can work with URL generation
*
* @return void
*/
Expand Down Expand Up @@ -916,7 +911,7 @@ public function testMethodCompatibility()
}

/**
* Test that patterns work for :action
* test that patterns work for :action
*
* @return void
*/
Expand Down Expand Up @@ -947,7 +942,7 @@ public function testPatternOnAction()
}

/**
* Test the parseArgs method
* test the parseArgs method
*
* @return void
*/
Expand Down Expand Up @@ -1002,7 +997,7 @@ public function testMatchTrailing()
}

/**
* Test restructuring args with pass key
* test restructuring args with pass key
*
* @return void
*/
Expand Down Expand Up @@ -1068,7 +1063,7 @@ public function testParseTrailingUTF8()
}

/**
* Test getName();
* test getName();
*
* @return void
*/
Expand Down Expand Up @@ -1149,7 +1144,7 @@ public function testGetNamePrefix()
}

/**
* Test that utf-8 patterns work for :section
* test that utf-8 patterns work for :section
*
* @return void
*/
Expand Down

0 comments on commit aa8f1ac

Please sign in to comment.