Rename new methods to clarify their intention

cakephp · Apr 27, 2017 · b1379f6 · b1379f6
1 parent 934c76c
commit b1379f6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/Error/Debugger.php b/src/Error/Debugger.php
@@ -655,7 +655,7 @@ protected static function _object($var, $depth, $indent)
      *
      * @return string Returns the current format when getting.
      */
-    public static function getOutputAs()
+    public static function getOutputFormat()
     {
         return Debugger::getInstance()->_outputFormat;
     }
@@ -667,7 +667,7 @@ public static function getOutputAs()
      * @return void
      * @throws \InvalidArgumentException When choosing a format that doesn't exist.
      */
-    public static function setOutputAs($format)
+    public static function setOutputFormat($format)
     {
         $self = Debugger::getInstance();
 
@@ -680,7 +680,7 @@ public static function setOutputAs($format)
     /**
      * Get/Set the output format for Debugger error rendering.
      *
-     * @deprecated 3.5.0 Use getOutputAs()/setOutputAs() instead.
+     * @deprecated 3.5.0 Use getOutputFormat()/setOutputFormat() instead.
      * @param string|null $format The format you want errors to be output as.
      *   Leave null to get the current format.
      * @return string|null Returns null when setting. Returns the current format when getting.

diff --git a/tests/TestCase/Error/DebuggerTest.php b/tests/TestCase/Error/DebuggerTest.php
@@ -154,14 +154,14 @@ public function testOutputAsException()
     }
 
     /**
-     * Test that getOutputAs/setOutputAs works.
+     * Test that getOutputFormat/setOutputFormat works.
      *
      * @return void
      */
-    public function testGetSetOutputAs()
+    public function testGetSetOutputFormat()
     {
-        Debugger::setOutputAs('html');
-        $this->assertEquals('html', Debugger::getOutputAs());
+        Debugger::setOutputFormat('html');
+        $this->assertEquals('html', Debugger::getOutputFormat());
     }
 
     /**
@@ -172,7 +172,7 @@ public function testGetSetOutputAs()
      */
     public function testSetOutputAsException()
     {
-        Debugger::setOutputAs('Invalid junk');
+        Debugger::setOutputFormat('Invalid junk');
     }
 
     /**