Do not underscore in console output to minimize distraction

cakephp · Apr 23, 2015 · b297279 · b297279
1 parent bc35e7b
commit b297279
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/Console/ConsoleOutput.php b/src/Console/ConsoleOutput.php
@@ -138,10 +138,10 @@ class ConsoleOutput
      * @var array
      */
     protected static $_styles = [
-        'emergency' => ['text' => 'red', 'underline' => true],
-        'alert' => ['text' => 'red', 'underline' => true],
-        'critical' => ['text' => 'red', 'underline' => true],
-        'error' => ['text' => 'red', 'underline' => true],
+        'emergency' => ['text' => 'red'],
+        'alert' => ['text' => 'red'],
+        'critical' => ['text' => 'red'],
+        'error' => ['text' => 'red'],
         'warning' => ['text' => 'yellow'],
         'info' => ['text' => 'cyan'],
         'debug' => ['text' => 'yellow'],

diff --git a/tests/TestCase/Console/ConsoleOutputTest.php b/tests/TestCase/Console/ConsoleOutputTest.php
@@ -109,7 +109,7 @@ public function testWriteArray()
     public function testStylesGet()
     {
         $result = $this->output->styles('error');
-        $expected = ['text' => 'red', 'underline' => true];
+        $expected = ['text' => 'red'];
         $this->assertEquals($expected, $result);
 
         $this->assertNull($this->output->styles('made_up_goop'));
@@ -143,7 +143,7 @@ public function testStylesAdding()
     public function testFormattingSimple()
     {
         $this->output->expects($this->once())->method('_write')
-            ->with("\033[31;4mError:\033[0m Something bad");
+            ->with("\033[31mError:\033[0m Something bad");
 
         $this->output->write('<error>Error:</error> Something bad', false);
     }
@@ -202,7 +202,7 @@ public function testFormattingMissingStyleName()
     public function testFormattingMultipleStylesName()
     {
         $this->output->expects($this->once())->method('_write')
-            ->with("\033[31;4mBad\033[0m \033[33mWarning\033[0m Regular");
+            ->with("\033[31mBad\033[0m \033[33mWarning\033[0m Regular");
 
         $this->output->write('<error>Bad</error> <warning>Warning</warning> Regular', false);
     }
@@ -215,7 +215,7 @@ public function testFormattingMultipleStylesName()
     public function testFormattingMultipleSameTags()
     {
         $this->output->expects($this->once())->method('_write')
-            ->with("\033[31;4mBad\033[0m \033[31;4mWarning\033[0m Regular");
+            ->with("\033[31mBad\033[0m \033[31mWarning\033[0m Regular");
 
         $this->output->write('<error>Bad</error> <error>Warning</error> Regular', false);
     }