Add indexSql method to SqliteSchema.

Add the method and some tests.
cakephp · May 14, 2013 · b2b9f29 · b2b9f29
1 parent b9e92de
commit b2b9f29
Show file tree

Hide file tree

Showing 2 changed files with 52 additions and 0 deletions.
diff --git a/lib/Cake/Database/Schema/SqliteSchema.php b/lib/Cake/Database/Schema/SqliteSchema.php
@@ -202,6 +202,19 @@ public function columnSql(Table $table, $name) {
  */
 	public function indexSql(Table $table, $name) {
 		$data = $table->index($name);
+		$out = 'CONSTRAINT ';
+		$out .= $this->_driver->quoteIdentifier($name);
+		if ($data['type'] === Table::INDEX_PRIMARY) {
+			$out .= ' PRIMARY KEY';
+		}
+		if ($data['type'] === Table::INDEX_UNIQUE) {
+			$out .= ' UNIQUE';
+		}
+		$columns = array_map(
+			[$this->_driver, 'quoteIdentifier'],
+			$data['columns']
+		);
+		return $out . ' (' . implode(', ', $columns) . ')';
 	}
 
 /**

diff --git a/lib/Cake/Test/TestCase/Database/Schema/SqliteSchemaTest.php b/lib/Cake/Test/TestCase/Database/Schema/SqliteSchemaTest.php
@@ -376,6 +376,45 @@ public function testColumnSql($name, $data, $expected) {
 		$this->assertEquals($expected, $schema->columnSql($table, $name));
 	}
 
+/**
+ * Provide data for testing indexSql
+ *
+ * @return array
+ */
+	public static function indexSqlProvider() {
+		return [
+			[
+				'primary',
+				['type' => 'primary', 'columns' => ['title']],
+				'CONSTRAINT "primary" PRIMARY KEY ("title")'
+			],
+			[
+				'unique_idx',
+				['type' => 'unique', 'columns' => ['title', 'author_id']],
+				'CONSTRAINT "unique_idx" UNIQUE ("title", "author_id")'
+			],
+		];
+	}
+
+/**
+ * Test the indexSql method.
+ *
+ * @dataProvider indexSqlProvider
+ */
+	public function testIndexSql($name, $data, $expected) {
+		$driver = $this->_getMockedDriver();
+		$schema = new SqliteSchema($driver);
+
+		$table = (new Table('articles'))->addColumn('title', [
+			'type' => 'string',
+			'length' => 255
+		])->addColumn('author_id', [
+			'type' => 'integer',
+		])->addIndex($name, $data);
+
+		$this->assertEquals($expected, $schema->indexSql($table, $name));
+	}
+
 /**
  * Get a schema instance with a mocked driver/pdo instances
  *