Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
make the following "just work" curl -X PUT -d foo=bar http://...
- Loading branch information
Showing
2 changed files
with
110 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b509bdb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When merging and rebasing this code into my router/request branch for 3.0, I added support for
PATCH
andDELETE
. Might make sense to add that to 2.2 as well. markstory/cakephp@e8680f6b509bdb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to add it to 2.2
b509bdb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added PUT/DELETE in 5467902 and updated the docs. :)
b509bdb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
win!
Why leave out patch though?
Are we going to get into semantic debates with users in the future as to why we aren't using PATCH for (partial) edit actions I wonder..
b509bdb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have patch in for 3.0, I guess we could add a
is('patch')
detector too. I hope we don't have that fight, its really not worth the time and effort.