Skip to content

Commit

Permalink
Fix default installation path for vendors.
Browse files Browse the repository at this point in the history 
By default global vendors go into `/vendors`. This config change helps
people get started with less friction. I've removed debugkit as
a dependency, as it isn't _really_ a dependency for CakePHP itself.

Refs #8765
  • Loading branch information
@markstory
markstory committed May 18, 2016
1 parent 3265831 commit c02b269
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion composer.json
View file
Expand Up @@ -23,9 +23,11 @@
},
"require-dev": {
"phpunit/phpunit": "3.7.*",
"cakephp/debug_kit" : "^2.2.0",
"cakephp/cakephp-codesniffer": "^1.0.0"
},
"config": {
"vendor-dir": "vendors/"
},
"bin": [
"lib/Cake/Console/cake"
]
Expand Down

2 comments on commit c02b269

@davidyell
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you could give more explanation as to why this matters? Why is it different from the Composer standard of /vendor ?

@dereuromark
Copy link
Member

@dereuromark dereuromark commented on c02b269 Oct 5, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is was and is the 2.x convention and default folder for vendor classes. It just always has been called "vendors" in this directory and also exists like this in the default skeleton, thus the config here.
You can just as well use something else, of course, but that might require some changes in the App::vendor() usage, as it by default tries to look into that folder.

Please sign in to comment.