Names starting with spaces are invalid.

cakephp · Oct 5, 2017 · ccee4f5 · ccee4f5
1 parent 1a0c868
commit ccee4f5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/Console/Command.php b/src/Console/Command.php
@@ -77,7 +77,7 @@ public function __construct()
      */
     public function setName($name)
     {
-        if (strpos($name, ' ') === false) {
+        if (strpos($name, ' ') < 1) {
             throw new InvalidArgumentException(
                 "The name '{$name}' is missing a space. Names should look like `cake routes`"
             );

diff --git a/tests/TestCase/Console/CommandTest.php b/tests/TestCase/Console/CommandTest.php
@@ -77,6 +77,18 @@ public function testSetNameInvalid()
         $command->setName('routes_show');
     }
 
+    /**
+     * Test invalid name
+     *
+     * @expectedException InvalidArgumentException
+     * @return void
+     */
+    public function testSetNameInvalidLeadingSpace()
+    {
+        $command = new Command();
+        $command->setName(' routes_show');
+    }
+
     /**
      * Test option parser fetching
      *