Add check for valid output type

cakephp · Apr 17, 2017 · ce8bc83 · ce8bc83
1 parent 781466c
commit ce8bc83
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/src/Console/ConsoleOutput.php b/src/Console/ConsoleOutput.php
@@ -14,6 +14,8 @@
  */
 namespace Cake\Console;
 
+use InvalidArgumentException;
+
 /**
  * Object wrapper for outputting information from a shell application.
  * Can be connected to any stream resource that can be used with fopen()
@@ -317,9 +319,14 @@ public function getOutputAs()
      *
      * @param int $type The output type to use. Should be one of the class constants.
      * @return void
+     * @throws InvalidArgumentException in case of a not supported output type.
      */
     public function setOutputAs($type)
     {
+        if (in_array($type, [self::RAW, self::PLAIN, self::COLOR], true) === false) {
+            throw new InvalidArgumentException(sprintf('Invalid output type "%s".', $type));
+        }
+
         $this->_outputAs = $type;
     }
 

diff --git a/tests/TestCase/Console/ConsoleOutputTest.php b/tests/TestCase/Console/ConsoleOutputTest.php
@@ -263,6 +263,17 @@ public function testSetOutputAsPlain()
         $this->output->write('<error>Bad</error> Regular', false);
     }
 
+    /**
+     * test set wrong type.
+     *
+     * @expectedException \InvalidArgumentException
+     * @expectedExceptionMessage Invalid output type "Foo".
+     */
+    public function testSetOutputWrongType()
+    {
+        $this->output->setOutputAs('Foo');
+    }
+
     /**
      * test plain output only strips tags used for formatting.
      *