Update join building to not error out on empty conditions.

When conditions are empty we can assume one of two things:

* The person made a mistake.
* The person is doing the join conditions in the where clause.

In both cases we should attempt to generate proper SQL.

Fixes #4189

Author: markstory

lib/Cake/Model/Datasource/DboSource.php

@@ -1865,7 +1865,7 @@ public function buildJoinStatement($join) {
 			'type' => null,
 			'alias' => null,
 			'table' => 'join_table',
-			'conditions' => array()
+			'conditions' => '',
 		), $join);
 
 		if (!empty($data['alias'])) {
@@ -1919,7 +1919,7 @@ public function buildStatement($query, Model $Model) {
  * @return string
  */
 	public function renderJoinStatement($data) {
-		if (strtoupper($data['type']) === 'CROSS') {
+		if (strtoupper($data['type']) === 'CROSS' || empty($data['conditions'])) {
 			return "{$data['type']} JOIN {$data['table']} {$data['alias']}";
 		}
 		return trim("{$data['type']} JOIN {$data['table']} {$data['alias']} ON ({$data['conditions']})");

lib/Cake/Test/Case/Model/Datasource/DboSourceTest.php

@@ -1197,6 +1197,11 @@ public static function joinStatements() {
 				'table' => 'posts_tags',
 				'conditions' => array('1 = 1')
 			), 'CROSS JOIN cakephp.posts_tags AS PostsTag'),
+			array(array(
+				'type' => 'LEFT',
+				'alias' => 'PostsTag',
+				'table' => 'posts_tags',
+			), 'LEFT JOIN cakephp.posts_tags AS PostsTag'),
 			array(array(
 				'type' => 'LEFT',
 				'alias' => 'PostsTag',