Fix more issues reported by PHPStan

cakephp · Feb 15, 2018 · d4a4887 · d4a4887
1 parent 8b33c9f
commit d4a4887
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/src/Console/CommandRunner.php b/src/Console/CommandRunner.php
@@ -25,7 +25,6 @@
 use Cake\Core\PluginApplicationInterface;
 use Cake\Event\EventDispatcherInterface;
 use Cake\Event\EventDispatcherTrait;
-use Cake\Event\EventManagerTrait;
 use Cake\Utility\Inflector;
 use RuntimeException;
 
@@ -114,9 +113,8 @@ public function setAliases(array $aliases)
      */
     public function run(array $argv, ConsoleIo $io = null)
     {
-        $hasPlugins = $this->app instanceof PluginApplicationInterface;
         $this->app->bootstrap();
-        if ($hasPlugins) {
+        if ($this->app instanceof PluginApplicationInterface) {
             $this->app->pluginBootstrap();
         }
 
@@ -125,7 +123,7 @@ public function run(array $argv, ConsoleIo $io = null)
             'help' => HelpCommand::class,
         ]);
         $commands = $this->app->console($commands);
-        if ($hasPlugins) {
+        if ($this->app instanceof PluginApplicationInterface) {
             $commands = $this->app->pluginConsole($commands);
         }
 

diff --git a/src/Http/BaseApplication.php b/src/Http/BaseApplication.php
@@ -18,7 +18,6 @@
 use Cake\Core\HttpApplicationInterface;
 use Cake\Core\Plugin;
 use Cake\Core\PluginApplicationInterface;
-use Cake\Core\PluginCollection;
 use Cake\Core\PluginInterface;
 use Cake\Routing\DispatcherFactory;
 use Cake\Routing\Router;
@@ -47,7 +46,7 @@ abstract class BaseApplication implements
     /**
      * Plugin Collection
      *
-     * @param \Cake\Core\PluginCollection
+     * @var \Cake\Core\PluginCollection
      */
     protected $plugins;
 

diff --git a/src/Http/Server.php b/src/Http/Server.php
@@ -70,16 +70,15 @@ public function __construct(HttpApplicationInterface $app)
     public function run(ServerRequestInterface $request = null, ResponseInterface $response = null)
     {
         $this->app->bootstrap();
-        $hasPlugins = $this->app instanceof PluginApplicationInterface;
-        if ($hasPlugins) {
+        if ($this->app instanceof PluginApplicationInterface) {
             $this->app->pluginBootstrap();
         }
 
         $response = $response ?: new Response();
         $request = $request ?: ServerRequestFactory::fromGlobals();
 
         $middleware = $this->app->middleware(new MiddlewareQueue());
-        if ($hasPlugins) {
+        if ($this->app instanceof PluginApplicationInterface) {
             $middleware = $this->app->pluginMiddleware($middleware);
         }