Skip to content

Commit

Permalink
Improving styles for url rewriting detection notice, and copying it t…
Browse files Browse the repository at this point in the history 
…o the skel app
  • Loading branch information
@lorenzo
lorenzo committed May 30, 2011
1 parent 3f58509 commit d51e902
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 3 deletions.
15 changes: 15 additions & 0 deletions cake/console/templates/default/views/home.ctp
View file
Expand Up @@ -19,6 +19,21 @@ endif;
endif;
?>
</p>
<div style=\"background-color:#e32; color:#fff; padding:3px; margin: 20px 0\">
<?php __('URL rewriting is not properly configured on your server. '); ?>
<ol style=\"padding-left:20px\">
<li>
<a target=\"_blank\" href=\"http://book.cakephp.org/view/917/Apache-and-mod_rewrite-and-htaccess\" style=\"color:#fff;\">
<?php __('Help me configure it')?>
</a>
</li>
<li>
<a target=\"_blank\" href=\"http://book.cakephp.org/view/931/CakePHP-Core-Configuration-Variables\" style=\"color:#fff;\">
<?php __('I don\'t / can\'t use URL rewriting')?>
</a>
</li>
</ol>
</div>
<p>
<?php
\$settings = Cache::settings();
Expand Down
16 changes: 13 additions & 3 deletions cake/libs/view/pages/home.ctp
View file
Expand Up @@ -27,10 +27,20 @@ if (Configure::read() > 0):
Debugger::checkSecurityKeys();
endif;
?>
<div id="url-rewriting-warning" style="background-color:#e32; color:#fff; padding:3px;">
<div style="background-color:#e32; color:#fff; padding:3px; margin: 20px 0">
<?php __('URL rewriting is not properly configured on your server. '); ?>
1) <a target="_blank" href="http://book.cakephp.org/view/917/Apache-and-mod_rewrite-and-htaccess" style="color:#fff;">Help me configure it</a>
2) <a target="_blank" href="http://book.cakephp.org/view/931/CakePHP-Core-Configuration-Variables" style="color:#fff;">I don't / can't use URL rewriting</a>
<ol style="padding-left:20px">
<li>
<a target="_blank" href="http://book.cakephp.org/view/917/Apache-and-mod_rewrite-and-htaccess" style="color:#fff;">
<?php __('Help me configure it')?>
</a>
</li>
<li>
<a target="_blank" href="http://book.cakephp.org/view/931/CakePHP-Core-Configuration-Variables" style="color:#fff;">
<?php __('I don\'t / can\'t use URL rewriting')?>
</a>
</li>
</ol>
</div>
<p>
<?php
Expand Down

3 comments on commit d51e902

@voidet
Copy link
Contributor

@voidet voidet commented on d51e902 Jul 18, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be best to include the div id tag back in #url-rewriting-warning

@lorenzo
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, if the rewriting is not working properly, then the red style would not be present :)

@ADmad
Copy link
Member

@ADmad ADmad commented on d51e902 Jul 20, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@voidet This is an old commit. The current version of the files on 1.3 branch do have the div id #url-rewriting-warning.

Please sign in to comment.