Remove setSession()

src/Http/ServerRequest.php

@@ -514,23 +514,6 @@ public function contentType()
         return $this->env('HTTP_CONTENT_TYPE');
     }
 
-    /**
-     * Update the request with a new session instance.
-     *
-     * Returns an updated request object. This method returns
-     * a *new* request object and does not mutate the request in-place.
-     *
-     * @param \Cake\Network\Session $session the session object to use
-     * @return static
-     */
-    public function withSession(Session $session)
-    {
-        $new = clone $this;
-        $new->session = $session;
-
-        return $new;
-    }
-
     /**
      * Returns the instance of the Session object for this request
      *
@@ -547,7 +530,7 @@ public function getSession()
      * If a session object is passed as first argument it will be set as
      * the session to use for this request
      *
-     * @deprecated 3.5.0 Use getSession()/withSession() instead.
+     * @deprecated 3.5.0 Use getSession() instead. The setter part will be removed.
      * @param \Cake\Network\Session|null $session the session object to use
      * @return \Cake\Network\Session
      */

tests/TestCase/Http/ServerRequestTest.php

@@ -3193,20 +3193,6 @@ public function testGetSession()
         $this->assertEquals($session, $request->getSession());
     }
 
-    /**
-     * Tests setting the session to the request
-     *
-     * @return void
-     */
-    public function testWithtSession()
-    {
-        $session = new Session;
-        $request = new ServerRequest();
-        $newRequest = $request->withSession($session);
-        $this->assertNotSame($newRequest, $request);
-        $this->assertSame($session, $newRequest->getSession());
-    }
-
     /**
      * Test the content type method.
      *