Fixing form action attributes being double encoded with

querystring attributes. Fixes #1748
cakephp · Jun 23, 2011 · d6e262d · d6e262d
1 parent 68378f2
commit d6e262d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/Cake/View/Helper/FormHelper.php b/lib/Cake/View/Helper/FormHelper.php
@@ -314,7 +314,8 @@ public function create($model = null, $options = array()) {
 		}
 		$this->requestType = strtolower($options['type']);
 
-		$htmlAttributes['action'] = $this->url($options['action']);
+
+		$action = $this->url($options['action']);
 		unset($options['type'], $options['action']);
 
 		if ($options['default'] == false) {
@@ -351,7 +352,7 @@ public function create($model = null, $options = array()) {
 		}
 
 		$this->setEntity($model . '.', true);
-		return $this->Html->useTag('form', $htmlAttributes) . $append;
+		return $this->Html->useTag('form', $action, $htmlAttributes) . $append;
 	}
 
 /**

diff --git a/lib/Cake/View/Helper/HtmlHelper.php b/lib/Cake/View/Helper/HtmlHelper.php
@@ -38,7 +38,7 @@ class HtmlHelper extends AppHelper {
 		'metalink' => '<link href="%s"%s/>',
 		'link' => '<a href="%s"%s>%s</a>',
 		'mailto' => '<a href="mailto:%s" %s>%s</a>',
-		'form' => '<form%s>',
+		'form' => '<form action="%s"%s>',
 		'formend' => '</form>',
 		'input' => '<input name="%s"%s/>',
 		'textarea' => '<textarea name="%s"%s>%s</textarea>',