give to phpcs what it wants

cakephp · Jun 27, 2016 · d751087 · d751087
1 parent 41289ed
commit d751087
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 4 deletions.
diff --git a/src/Shell/Helper/TableHelper.php b/src/Shell/Helper/TableHelper.php
@@ -78,7 +78,7 @@ protected function _rowSeparator($widths)
      */
     protected function _render($row, $widths, $options = [])
     {
-        if(!$row || !is_array($row)) {
+        if (!$row || !is_array($row)) {
             return;
         }
 
@@ -102,7 +102,7 @@ protected function _render($row, $widths, $options = [])
      */
     public function output($rows)
     {
-        if(!$rows || !is_array($rows)) {
+        if (!$rows || !is_array($rows)) {
             return;
         }
 
@@ -115,7 +115,7 @@ public function output($rows)
             $this->_rowSeparator($widths);
         }
 
-        if(!$rows) {
+        if (!$rows) {
             return;
         }
 

diff --git a/tests/TestCase/Shell/Helper/TableHelperTest.php b/tests/TestCase/Shell/Helper/TableHelperTest.php
@@ -64,7 +64,7 @@ public function testDefaultOutput()
     }
 
     /**
-     * Test output with multibyte characters
+     * Test output with multi-byte characters
      *
      * @return void
      */
@@ -209,4 +209,40 @@ public function testOutputWithRowSeparatorAndHeaders()
         ];
         $this->assertEquals($expected, $this->stub->messages());
     }
+
+    /**
+     * Test output when there is no data.
+     */
+    public function testOutputWithNoData()
+    {
+        $this->helper->output([]);
+        $this->assertEquals([], $this->stub->messages());
+    }
+
+    /**
+     * Test output with a header but no data.
+     */
+    public function testOutputWithHeaderAndNoData()
+    {
+        $data = [
+            ['Header 1', 'Header', 'Long Header']
+        ];
+        $this->helper->output($data);
+        $expected = [
+            '+----------+--------+-------------+',
+            '| <info>Header 1</info> | <info>Header</info> | <info>Long Header</info> |',
+            '+----------+--------+-------------+',
+        ];
+        $this->assertEquals($expected, $this->stub->messages());
+    }
+
+    /**
+     * Test no data when headers are disabled.
+     */
+    public function testOutputHeaderDisabledNoData()
+    {
+        $this->helper->config(['header' => false]);
+        $this->helper->output([]);
+        $this->assertEquals([], $this->stub->messages());
+    }
 }